-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add registry option to download commands #893
Add registry option to download commands #893
Conversation
Can you please help me to understand, do you plan to set different global |
@giggsoff eve-update tests are using |
Seems it does not work (checked your branch):
|
9b0e996
to
e6d7504
Compare
@giggsoff you're right, using set default overrides default values set in flags by |
Please update both tests (http and oci) using novel registry option (I mean move it on top of file the same way you do it for http test). And use different versions of EVE-OS in tests as they will not re-downloaded if exists in different partition (not sure how it works now, but it is separate question, we do not plan to check it here). |
@giggsoff but oci test is not using utils download it directly tries to download from lf-edge/eve oci registry, so I don't see the point of updating it. Will bump EVE version though |
e6d7504
to
272ee58
Compare
Two points:
|
New eden workflows take eve registry and tag as a parameter and set it up as default. During eve upgrade testing `eden utils download eve-rootfs` is called which is using default registry, however intended behaviour would be to use `lf-edge/eve` registry. Adding this parameter and setting it in upgrade test makes download util use lf-edge/eve registry Signed-off-by: Pavel Abramov <[email protected]>
272ee58
to
d333713
Compare
@giggsoff updated PR to use registry for OCI from variables and use two different EVE versions in OCI and HTTP tests |
New eden workflows take eve registry and tag as a parameter and set it up as default. During eve upgrade testing
eden utils download eve-rootfs
is called which is using default registry, however intended behaviour would be to uself-edge/eve
registry. Adding this parameter and default value makes download util use lf-edge/eve registry by default.This does not break behaviour in workflows